muvm: Add a --passt-args argument to pass args to passt#224
Merged
Conversation
teohhanhui
reviewed
May 7, 2026
f003a59 to
84ea109
Compare
teohhanhui
reviewed
May 7, 2026
teohhanhui
reviewed
May 7, 2026
Member
|
Thinking of it, how bad would it be to instead do args "compiler driver"-style, so everything preceded by, say, -P gets sent to passt, and we do not do any shell expansion of our own? Eg: |
Collaborator
|
I think that would only make sense if we expect that passing passt-args would be a common usage? |
Member
Opposite, actually, this simplifies word splitting and does not need pulling in an extra crate in exchange for a slightly less convenient syntax |
Collaborator
|
IMO short names are a very limited resource. |
Contributor
Author
|
Well we coooould do that style with a long arg, I guess xD |
e2cbcd8 to
5566c15
Compare
teohhanhui
reviewed
May 7, 2026
5566c15 to
c144515
Compare
teohhanhui
reviewed
May 7, 2026
Sometimes it's necessary to pass additional args (such as the network interface) to passt. It's already been possible to spawn passt externally and give muvm its socket, but that's inconvenient especially when one wants to keep using the nicer muvm syntax for the exposed ports. Signed-off-by: Val Packett <val@invisiblethingslab.com>
c144515 to
c82d655
Compare
teohhanhui
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes it's necessary to pass additional args (such as the network interface) to passt. It's already been possible to spawn passt externally and give muvm its socket, but that's inconvenient especially when one wants to keep using the nicer muvm syntax for the exposed ports.