battle phases now in notes#1409
Open
Palladium103 wants to merge 2 commits intoAzgaar:masterfrom
Open
Conversation
✅ Deploy Preview for afmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the legacy battle UI so battlefield notes can include the attacker/defender phase progression when a battle is applied, adding more simulation detail to the generated marker note text.
Changes:
- Adds battle-instance state to accumulate phase history across iterations.
- Records attacker/defender phase pairs during battle runs.
- Appends the collected phase history to the generated battlefield note legend.
… and also when user changes the phase manually
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Battle notes will now include the phases of the attacker and defender in such format,
Defender: skirmish, Attacker: skirmish
Defender: skirmish, Attacker: bombardment
Defender: melee, Attacker: melee