SCENARIO: Linking an existing document (see #383).#392
SCENARIO: Linking an existing document (see #383).#392Come-Peyrelongue wants to merge 2 commits into
Conversation
Come-Peyrelongue
added
the
Good first issue
|
@Come-Peyrelongue @LeMouj @sachaS456 It seems that your I strongly recommend using Git Fork for the intensive git history rewriting done in IF05. |
|
Please note also that the pull request should be in draft mode until it is complete (with scenario, tests and implementation). |
|
Thank you for your contribution @sachaS456 @Come-Peyrelongue @LeMouj Please don't forget that your pull request won't be integrated if your commits they don't follow strict naming conventions. It is quite easy with Git-Fork. See how it was done for a different issue: #390 (comment) Please note that the videos also show how |
benel
left a comment
benel
left a comment
There was a problem hiding this comment.
@Come-Peyrelongue @sachaS456 @LeMouj
Thank you very much for your contribution. Please consider my review so that acceptance tests fully comply with BDD.
Regards.
| cy.get('.document-list-container .existingDocument') | ||
| .should('have.length.greaterThan', 0) | ||
| .each(($card) => { | ||
| cy.wrap($card).find('span').invoke('text').should('match', /\S+/); |
There was a problem hiding this comment.
As explained in the comment of the scenario, move this condition into Quand je réutilise {string} comme glose.
| "Bolo to raz" (svk) | ||
| "Comments on the video - Côme Peyrelongue, 24/03/2026 09:32 - My First Video Document" | ||
| "My Second Video Document - Côme Peyrelongue, 10/03/2026 20:15" | ||
| "Comments on the video - Côme Peyrelongue, 23/03/2026 10:44 - My Second Video Document" |
There was a problem hiding this comment.
- I see no reason to remove the existing scenario. It is really useful to check that its contents is linked and displayed.
- I don't understand how you can be sure that everyone with just the code base, at any step of the tests will have your own documents. Nothing in the scenario tells that you should have them. And nothing in tests or data samples can make this assumption true.
- Because your improvement is only a small part of
Quand je réutilise {string} comme glose, you don't have to change the scenario: you just have to add conditions into the implementation of your test step.
It is important to understand all three objections. However if you take into account the third one it will fix the other two.
|
Thank you for your updates @sachaS456 @Come-Peyrelongue @LeMouj Please note that one of your acceptance tests failed:
|
4 participants
Updated the scenario to include comments on video documents and modified the expected document list.
Co-authored-by: Enzo MOUGIN enzo.mougin@utt.fr
Co-authored-by: Côme PEYRELONGUE come.peyrelongue@utt.fr
Co-authored-by: Sacha HIMBER sacha.himber@utt.fr
We, Enzo MOUGIN, Côme PEYRELONGUE & Sacha HIMBER, hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.