docs: add supervisor image Helm values to manage-gateways reference#1214
Open
mesutoezdil wants to merge 1 commit intoNVIDIA:mainfrom
Open
docs: add supervisor image Helm values to manage-gateways reference#1214mesutoezdil wants to merge 1 commit intoNVIDIA:mainfrom
mesutoezdil wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
mesutoezdil
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
The supervisor init container was introduced in NVIDIA#1154 but the three `supervisor.image.*` values were missing from the Helm values reference table in the manage-gateways doc. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
mesutoezdil
force-pushed
the
docs/helm-supervisor-image-values
branch
from
6194261 to
76841e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The supervisor init container was introduced in #1154 but the three `supervisor.image.*` Helm values were not documented.
After #1231 removed the Helm deployment section from `manage-gateways.mdx`, the natural home for chart configuration is `deploy/helm/openshell/README.md`. This PR adds a configuration reference table there, which is where `docs/about/installation.mdx` directs Kubernetes users for chart configuration details.
Added values:
The table also restores the other commonly configured values that were lost when `manage-gateways.mdx` was consolidated.
Related Issue
Follows #1154. Rebased after #1231.
Changes
Testing
Documentation change only. No code changes.
Checklist