feat(gpu): honor device IDs in Docker and Podman#1253
Open
Conversation
dc3cae4 to
9735e15
Compare
|
Label |
5af3636 to
3517ac2
Compare
3517ac2 to
817a97a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Honor the existing GPU device ID field for Docker and Podman GPU sandboxes without changing the protobuf API shape.
Related Issue
None.
Changes
nvidia.com/gpu=all, and invalid device IDs.e2e:gputo Docker GPU coverage and kept the previous Python GPU task available ase2e:k3s:gpu.Testing
cargo test --manifest-path e2e/rust/Cargo.toml --features e2e-docker-gpu --test gpu_device_selection --no-runcargo test --manifest-path e2e/rust/Cargo.toml --features e2e-podman-gpu --test gpu_device_selection --no-runcargo check -p openshell-cligit diff --check.github/workflows/e2e-gpu-test.yamlYAML parse checkmise taskslistse2e:gpu,e2e:k3s:gpu,e2e:docker:gpu, ande2e:python:gpumise run e2e:docker:gpuvalidated on a dGPU-based systemmise run markdown:lint:mdmise run pre-commitmise run e2e:podman:gpustill needs to be runChecklist