imagery: Update i.eodag for EODAG v4 compatibility

[polucifier]

Description

This PR updates the i.eodag module to ensure compatibility with the latest EODAG v4 release while maintaining full backward compatibility for users on EODAG v3.

Solves #1659

Changes

• EODAG v4 Support: Updated internal logic to handle Pydantic-based STAC objects, new property accessors, and the transition from productType to collection.
• Backward Compatibility: Implemented a compatibility layer to detect EODAG version and switch between v3/v4 API calls dynamically.
• Improved Testsuite: Updated test_eodag.py to adapt search parameters to the installed EODAG version.
• Code Cleanup: Removed obsolete TODOs and improved inline documentation/comments.

Verification

• Verified with EODAG v4.x.
• Verified with EODAG v3.x.
• All test_eodag.py tests passed in both environments.

[github-actions]

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

pre-commit

---

[pre-commit] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1368 in 0f87327

---

[pre-commit] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1396 in 0f87327

---

[pre-commit] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1402 in 0f87327

---

[pre-commit] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1426 in 0f87327

---

[pre-commit] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1428 in 0f87327

[github-actions]

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

ruff

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1099 in 0f87327

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1104 in 0f87327

p_id = p.get("ID") # This is fine for v3

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1107 in 0f87327

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1113 in 0f87327

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1116 in 0f87327

def print_eodag_queryables(eodag_api, **kwargs) -> None:

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1119 in 0f87327

The function extracts metadata (type, default value, and requirement)

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1136 in 0f87327

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1152 in 0f87327

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1156 in 0f87327

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1176 in 0f87327

if hasattr(potential_type, "__name__") and potential_type.__name__ == "Optional":

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Lines 1178 to 1179 in 0f87327

	q_dict["type"] = getattr(potential_type, "__name__", str(potential_type))

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1184 in 0f87327

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1187 in 0f87327

q_dict["type"] = "int" # Fallback assumption for v3 ranges

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1191 in 0f87327

if len(inner_args) > 0 and hasattr(inner_args[0], "__metadata__"):

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1195 in 0f87327

getattr(range_meta[1], "lt", None)

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1212 in 0f87327

def print_query(geometry, queryables, **kwargs) -> None:

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1261 in 0f87327

p["ID"] if isinstance(p, dict) else getattr(p, "id", str(p))

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1264 in 0f87327

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1267 in 0f87327

gs.fatal(_("Product type <{}> not available.").format(options["producttype"]))

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1310 in 0f87327

{pid.strip() for pid in options["id"].split(",")}, # product.id is consistent

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1316 in 0f87327

gs.verbose(_("Reading stored search result from file <{}>").format(options["file"]))

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1321 in 0f87327

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1325 in 0f87327

ids = {pid.strip() for pid in id_file.read_text(encoding="UTF8").strip().split("\n")}

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Lines 1328 to 1329 in 0f87327

	gs.fatal(_("Unable to read product IDs from file <{}>.").format(options["file"]))

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1332 in 0f87327

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Lines 1335 to 1336 in 0f87327

	dates_to_iso_format() # Validates date order and formats

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1338 in 0f87327

search_parameters = {

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1342 in 0f87327

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1347 in 0f87327

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1351 in 0f87327

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1354 in 0f87327

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1365 in 0f87327

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1368 in 0f87327

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1396 in 0f87327

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1402 in 0f87327

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1407 in 0f87327

gs.message(_("Please enter Creodias OTP (enter '-' to discard Creodias scenes): "))

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1411 in 0f87327

search_result = SearchResult([s for s in search_result if s.provider != "creodias"])

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1426 in 0f87327

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/i.eodag.py

Line 1428 in 0f87327

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/testsuite/test_eodag.py

Line 149 in 0f87327

flags="j", # Use -j to get JSON output for easier parsing

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/testsuite/test_eodag.py

Line 165 in 0f87327

scene_id = scene["id"] # Get ID directly from JSON output

---

[ruff] _{reported by reviewdog 🐶}

grass-addons/src/imagery/i.eodag/testsuite/test_eodag.py

Lines 263 to 265 in 0f87327

	sensor_mode = props.get("instrumentMode") or \
	props.get("platform:instrument:mode") or \
	props.get("sat:instrument_mode")

[ninsbl]

The code is not too easy to read with all the if-else-blocks.
Please consider using a mapping dict as suggested in my comment below...

[polucifier]

Addressed reviewers' feedbacks:

• Replaced all if EODAG_VERSION >= 4 / else branches with a EODAG_TEST_MAP dictionary that maps version → constants, making version-specific handling explicit and centralized
• Removed pyotp dependency and all unused imports (CalledModuleError, get_current_mapset, is_map_in_mapset)

Tested against both EODAG v3 and v4 — all 19 tests pass on both versions (excluding test_save_footprint which is intentionally skipped)

[landam]

I have successfully used the tool to download a sample Sentinel-2 scene from Copernicus Data Space using both EODAG versions 3.10 and 4.2. The tests also ran successfully (3.10 and 4.2) with one exception:

FAIL: test_text_file_with_ids (__main__.TestEodag.test_text_file_with_ids)
Test searching for products from a text file.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/grass84/etc/python/grass/gunittest/case.py", line 1394, in assertModule
    module.run()
  File "/usr/lib/grass84/etc/python/grass/pygrass/modules/interface/module.py", line 838, in run
    self.wait()
  File "/usr/lib/grass84/etc/python/grass/pygrass/modules/interface/module.py", line 859, in wait
    raise CalledModuleError(
grass.exceptions.CalledModuleError: Module run `i.eodag producttype=S2_MSI_L2A limit=50 file=testsuite/data/ids_list.txt provider=cop_dataspace sort=cloudcover order=asc timeout=300 wait=2 -l --q` ended with an error.
The subprocess ended with a non-zero return code: 1. See the following errors:
b'peps: could not create provider from scratch using config\ntheia: could not create provider from scratch using config\nonda: could not create provider from scratch using config\nastraea_eod: could not create provider from scratch using config\nearth_search_cog: could not create provider from scratch using config\nwekeo: could not create provider from scratch using config\nERROR: Could not open file "testsuite/data/ids_list.txt"\n'

This test doesn't fail on the original code, it's seems to be cased by this PR. @polucifier Can you take a look on this issue, please?

By the way when using EODAG v4.2 I am getting:

DeprecationWarning: Call to deprecated eodag function/method as_geojson_object (Please use 'SearchResult.as_dict' instead) -- Deprecated since v4.1.0

Would be nice to address this issue.

[polucifier]

This test doesn't fail on the original code, it's seems to be cased by this PR. @polucifier Can you take a look on this issue, please?

By the way when using EODAG v4.2 I am getting:

DeprecationWarning: Call to deprecated eodag function/method as_geojson_object (Please use 'SearchResult.as_dict' instead) -- Deprecated since v4.1.0

Would be nice to address this issue.

Hi @landam, thank you for the review. Both the test failure and the deprecation warning should be fixed now.