Sanitize strings to prevent UTF errors#2357
Open
jan-cerny wants to merge 1 commit into
Open
Conversation
jan-cerny
force-pushed
the
utf8_error
branch
3 times, most recently
from
915fc1c to
c2db8ec
Compare
If a string is collected by a probe, we will sanitize this string before converting it to SEXP. This will ensure that no errors related to UTF enconding can happen during the whole processing. This way we will fix multiple errors emitted by pcre2 or libxml2 libraries that are caused by providing non-UTF strings. Resolves: https://redhat.atlassian.net/browse/RHEL-171005
|
jan-cerny
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a string is collected by a probe, we will sanitize this string before converting it to SEXP. This will ensure that no errors related to UTF enconding can happen during the whole processing. This way we will fix multiple errors emitted by pcre2 or libxml2 libraries that are caused by providing non-UTF strings.
Resolves: https://redhat.atlassian.net/browse/RHEL-171005
Review hints:
touch /mnt/$(printf "evil_filename_\334_non_utf8_character")oscap xccdf eval --remediate --profile xccdf_org.ssgproject.content_profile_cis --rule xccdf_org.ssgproject.content_rule_audit_rules_privileged_commands /usr/share/xml/scap/ssg/content/ssg-rhel10-ds.xmloscap xccdf eval --profile xccdf_org.ssgproject.content_profile_cis --rule xccdf_org.ssgproject.content_rule_audit_rules_privileged_commands /usr/share/xml/scap/ssg/content/ssg-rhel10-ds.xml- this returnserrorwith latest released openscappass