rework command framework#59
Draft
timkpaine wants to merge 4 commits into
Draft
Conversation
Contributor
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
timkpaine
force-pushed
the
tkp/commandrework
branch
from
82c8446 to
c63df45
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
===========================================
+ Coverage 65.89% 76.76% +10.86%
===========================================
Files 28 33 +5
Lines 1639 2552 +913
Branches 166 204 +38
===========================================
+ Hits 1080 1959 +879
- Misses 527 549 +22
- Partials 32 44 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
…rmattedMessage executor.py — New _extract_attachments() helper converts FormattedImage/FormattedAttachment from a FormattedMessage into base Attachment objects; _coerce_response() now populates Message.attachments when returning a FormattedMessage echo.py — Replaced manual mention_users() calls with FormattedMessage + UserMention nodes help.py — Replaced per-backend if/elif rendering (Symphony <expandable-card>, Slack mrkdwn, Discord markdown table) with FormattedMessage + Heading + Table.from_dict_list() that auto-renders for each backend status.py — Same migration: builds a Table.from_dict_list() of metrics instead of manual **bold** markdown lines schedule.py — Same migration for the schedule listing test_command_framework.py — 3 new tests for _coerce_response() covering images in content, file attachments, and mixed content+attachments
timkpaine
force-pushed
the
tkp/commandrework
branch
from
345607e to
28944fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.