fix(car): refactor access tag analysis#7539
Open
DennisOSRM wants to merge 4 commits intomasterfrom
Open
Conversation
- Trim whitespace around each semicolon-separated part in Access.resolve_access, so values like 'destination; forestry' are correctly looked up in whitelist/blacklist sets. - Rename 'officials' → 'official' (standard OSM singular form) in car profile access blacklist, taginfo.json, and cucumber tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Lua for-loop variables are implicitly const; reassigning 'part' caused a runtime error. Use a separate 'trimmed' local instead, and store the trimmed value as 'best' for correct return. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4300.
This makes the access handling for the car profile more precise. The implementation also aided the decision on #4300.
We will keep routing on road segments that have invalid, or more precisely, unhandled access tags. There are two main reasons: