Skip to content

[C++][Stagging PR] Explore changes to migrate to C++20#1750

Draft
tdavidcl wants to merge 12 commits into
Shamrock-code:mainfrom
tdavidcl:patch-2026-04-14-01-28
Draft

[C++][Stagging PR] Explore changes to migrate to C++20#1750
tdavidcl wants to merge 12 commits into
Shamrock-code:mainfrom
tdavidcl:patch-2026-04-14-01-28

Conversation

@tdavidcl
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

Thanks @tdavidcl for opening this PR!

You can do multiple things directly here:
1 - Comment pre-commit.ci run to run pre-commit checks.
2 - Comment pre-commit.ci autofix to apply fixes.
3 - Add label autofix.ci to fix authorship & pre-commit for every commit made.
4 - Add label light-ci to only trigger a reduced & faster version of the CI (need the full one before merge).
5 - Add label trigger-ci to create an empty commit to trigger the CI.

Once the workflow completes a message will appear displaying informations related to the run.

Also the PR gets automatically reviewed by gemini, you can:
1 - Comment /gemini review to trigger a review
2 - Comment /gemini summary for a summary
3 - Tag it using @gemini-code-assist either in the PR or in review comments on files

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request transitions the project to C++20, updating CMake settings, lambda captures, and the source_location header. It also refactors string formatting across the codebase, including the introduction of a vformat utility. The review identifies an unnecessary template parameter in the vformat definition and recommends using fmt::format_string in print_buf to preserve compile-time format validation and simplify the code.

Comment thread src/shambase/include/shambase/string.hpp Outdated
Comment thread src/shamalgs/include/shamalgs/details/memory/memory.hpp
Comment thread src/shamalgs/include/shamalgs/details/memory/memory.hpp
tdavidcl added a commit to tdavidcl/Shamrock that referenced this pull request Apr 19, 2026
tdavidcl added a commit that referenced this pull request Apr 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 2, 2026

Workflow report

workflow report corresponding to commit c93ab33
Commiter email is 66853113+pre-commit-ci[bot]@users.noreply.github.com
You are using github private e-mail. This prevent proper tracing of who contributed what, please disable it (see Keep my email addresses private).

Light CI is enabled. This will only run the basic tests and not the full tests.
Merging a PR require the job "on PR / all" to pass which is disabled in this case.

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
cmake-format.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
ruff check...............................................................Passed
ruff format..............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed
No UTF-8 in files (except for authors)...................................Passed

Test pipeline can run.

Doxygen diff with main

Removed warnings : 0
New warnings : 0
Warnings count : 8232 → 8232 (0.0%)

Detailed changes :

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant