Skip to content

Manually complete fast-xml-parser 4.5.3 → 4.5.6 bump#484

Merged
Juanita-Dash merged 1 commit intomainfrom
bump-fast-xml-parser-4.5.6
May 8, 2026
Merged

Manually complete fast-xml-parser 4.5.3 → 4.5.6 bump#484
Juanita-Dash merged 1 commit intomainfrom
bump-fast-xml-parser-4.5.6

Conversation

@Juanita-Dash
Copy link
Copy Markdown
Contributor

Why

Dependabot PR #462 was titled as a fast-xml-parser bump (4.5.3 → 4.5.6) and merged green, but inspection of the merged commit (86fb324) shows the patch did not actually update fast-xml-parser in pnpm-lock.yaml — only unrelated transitive deps (@babel/parser, @jridgewell/trace-mapping, debug, jsesc) moved. All four fast-xml-parser@4.5.3 references remained on main post-merge.

This appears related to bumperbot bug Shopify/infrasec-bumper#673 — "Bumper handle nested manifests correctly". The infrasec deep-dive (Mar 11, Rune Madsen) flagged the same class of issue with fast-xml-parser specifically.

What

Reproduces the bump dependabot intended, by running:

pnpm update fast-xml-parser --lockfile-only --recursive

Result: 5 insertions / 5 deletions in pnpm-lock.yaml, all four references updated to 4.5.6 (package definitions + snapshot entries for @react-native-community/cli-platform-android@19.1.1 and cli-platform-ios@19.1.1). No package.json change — fast-xml-parser is purely transitive here.

Context

This unblocks the multirepo-denylist-check failure on shopify-playground/checkout-kit#31, which imports this lockfile verbatim under react-native/. Once this merges, that import PR will be re-synced from the new source main and the denylist check should clear.

cc @kieran-osgood-shopify @markmur @danielkift

Dependabot PR #462 was titled as a fast-xml-parser bump but the merged
patch did not actually move the version in pnpm-lock.yaml — only
unrelated transitive deps were updated. This appears related to the
known bumperbot bug Shopify/infrasec-bumper#673 (Bumper handle nested
manifests correctly).

This commit completes the bump by running:

  pnpm update fast-xml-parser --lockfile-only --recursive

which resolves all four lockfile references (package definitions and
snapshot entries for @react-native-community/cli-platform-android and
cli-platform-ios) to 4.5.6.

Unblocks the multirepo-denylist-check on the
shopify-playground/checkout-kit#31 import PR, which mirrors this
lockfile verbatim under react-native/.
@Juanita-Dash Juanita-Dash requested a review from a team as a code owner May 8, 2026 15:58
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Coverage Report

Lines Statements Branches Functions
Coverage: 99%
99.53% (214/215) 95.96% (119/124) 100% (64/64)

@Juanita-Dash Juanita-Dash merged commit a349b97 into main May 8, 2026
8 checks passed
@Juanita-Dash Juanita-Dash deleted the bump-fast-xml-parser-4.5.6 branch May 8, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants