Add pass to generate call graph .dot file#8689
Draft
stevenfontanella wants to merge 1 commit into
Draft
Conversation
Member
|
How does this compare to https://github.com/WebAssembly/binaryen/blob/main/src/passes/PrintCallGraph.cpp ? |
Member
Author
|
I didn't know we had that! It looks like that pass only creates edges for direct calls (there's some mention of indirect calls but it looks incomplete?). In this pass we include these three types of edges that aren't there in the existing pass, as well as nodes for function HeapTypes. I find this pass useful, maybe I can merge that into the existing pass with an option to print different types of edges? |
Member
|
sgtm to improve the existing pass. Maybe even without a new flag, just add to it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.