feat(mcp-chat): added shared libraires and extension points by fjudith · Pull Request #8370 · backstage/community-plugins

fjudith · 2026-03-30T00:42:40Z

Hey, I just made a Pull Request!

Starts the Implementation of #7976 following the adr011 and (superseeds #8196).

add the isomorphic package for shared types and future support for translations and permissions
add the node library to share the extension point between the backend and backend module

Current	> Phase 1 <	Phase 2

✔️ Checklist

A changeset describing the change and affected packages. (more info)
Added or updated documentation
Tests for new functionality and regression tests for bug fixes
Screenshots attached (for UI changes)
All your commits have a Signed-off-by line in the message. (more info)

backstage-goalie · 2026-03-30T00:47:26Z

Unexpected Changesets

The following changeset(s) reference packages that have not been changed in this PR:

/home/runner/work/community-plugins/community-plugins/workspaces/tech-insights/.changeset/cyan-ducks-mate.md: @backstage-community/plugin-tech-insights-maturity

Note that only changes that affect the published package require changesets, for example changes to tests and storybook stories do not require changesets.

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
@backstage-community/plugin-mcp-chat-backend	workspaces/mcp-chat/plugins/mcp-chat-backend	minor	`v0.11.0`
@backstage-community/plugin-mcp-chat-common	workspaces/mcp-chat/plugins/mcp-chat-common	minor	`v0.1.0`
@backstage-community/plugin-mcp-chat-node	workspaces/mcp-chat/plugins/mcp-chat-node	minor	`v0.1.0`
@backstage-community/plugin-mcp-chat	workspaces/mcp-chat/plugins/mcp-chat	minor	`v0.7.1`

fjudith · 2026-04-05T20:12:37Z

@Lucifergene the PR is ready for review

Lucifergene · 2026-05-02T19:36:14Z

This is a great work @fjudith
Need some more time to go through, but will get back soon.

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

…ckage Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

… package Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

see: comments backstage#8196 Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

Copilot

Pull request overview

Copilot reviewed 54 out of 56 changed files in this pull request and generated 8 comments.

Comments suppressed due to low confidence (1)

workspaces/mcp-chat/plugins/mcp-chat-common/src/types.ts:654

ConversationRow is described as an internal DB row shape, but it’s tagged @public which exposes it as part of the common package public API (and locks its schema for consumers). Either revert the tag to @internal (preferred for DB row types), or update the documentation to reflect that it’s intended for external consumption and stability guarantees apply.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Florian JUDITH <florian.judith.b@gmail.com>

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

doc: https://backstage.io/docs/backend-system/architecture/extension-points/#registering-an-extension-point Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

Copilot

Pull request overview

Copilot reviewed 54 out of 56 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (2)

workspaces/mcp-chat/plugins/mcp-chat-backend/src/services/MCPClientServiceImpl.ts:95

MCPClientServiceImpl initializes the LLM provider in the constructor (this.llmProvider = this.initializeLLMProvider();). Because provider modules register via the extension point during backend initialization, there’s no guarantee the extension-point providers have been registered before this constructor runs, which can cause the built-in factory path to be taken (or even throw) and the extension provider to be ignored for the lifetime of the service. Consider deferring LLM provider resolution until after initialization (e.g., lazily on first use), or wiring initialization so the plugin waits for provider registration before constructing MCPClientServiceImpl.

  constructor(options: Options) {
    this.logger = options.logger;
    this.config = options.config;
    this.extensionProviders = options.extensionProviders ?? new Map();
    this.toolCallTimeout =
      this.config.getOptionalNumber('mcpChat.toolCallTimeout') ??
      DEFAULT_MCP_TOOL_CALL_TIMEOUT_MS;
    this.llmProvider = this.initializeLLMProvider();
    this.mcpServers = this.initializeMCPServers();
    this.systemPrompt =
      this.config.getOptionalString('mcpChat.systemPrompt') ||
      "You are a helpful assistant. When using tools, provide a clear, readable summary of the results rather than showing raw data. Focus on answering the user's question with the information gathered.";
  }

workspaces/mcp-chat/plugins/mcp-chat-common/src/types.ts:654

The doc comment says ConversationRow is “Used internally for database operations”, but the TSDoc tag was changed to @public. If this type is meant to remain internal implementation detail, it should stay @internal (or be excluded from the public barrel exports). If it’s intentionally public now, please update the comment to reflect that it’s part of the supported API surface.

  private initializeLLMProvider(): LLMProvider {
    try {
      const providerConfig = getConfig(this.config);
+
+      // Check if an extension-point provider was registered for this type
+      const extensionProvider = this.extensionProviders.get(
+        providerConfig.type,
+      );
+      if (extensionProvider) {
+        this.logger.info(
+          `Using extension-point LLM Provider: ${providerConfig.type}, Model: ${providerConfig.model}`,
+        );
+        return extensionProvider;
+      }
+


+      // Check if an extension-point provider was registered for this type
+      const extensionProvider = this.extensionProviders.get(
+        providerConfig.type,
+      );
+      if (extensionProvider) {
+        this.logger.info(
+          `Using extension-point LLM Provider: ${providerConfig.type}, Model: ${providerConfig.model}`,
+        );
+        return extensionProvider;
+      }


+    const providers = new Map<string, LLMProvider>();
+
+    env.registerExtensionPoint(llmProviderExtensionPoint, {
+      registerProvider(type, provider) {
+        if (providers.has(type)) {
+          // As documented in the interface: replace and warn
+          console.warn(
+            `LLM provider with type '${type}' is already registered and will be replaced`,
+          );
+        }
+        providers.set(type, provider);
+      },


+  /** Maximum number of tokens to generate (default: 1000 for OpenAI-compatible, 4096 for Claude, 8192 for Gemini) */
+  maxTokens?: number;
+  /** Temperature for response randomness, between 0 and 1 (default: 0.7) */
+  temperature?: number;


fjudith requested review from a team, Eswaraiahsapram, Lucifergene and christoph-jerolimov as code owners March 30, 2026 00:42

fjudith requested a review from BethGriggs March 30, 2026 00:42

backstage-service added the workspace/mcp-chat label Mar 30, 2026

fjudith force-pushed the feat/mcp-chat-backend-v2a branch from 2ca5d06 to 5620679 Compare March 30, 2026 00:46

backstage deleted a comment from backstage-goalie Bot Mar 30, 2026

fjudith force-pushed the feat/mcp-chat-backend-v2a branch from f6bd506 to 23e0387 Compare March 30, 2026 00:55

christoph-jerolimov assigned Lucifergene Mar 30, 2026

fjudith force-pushed the feat/mcp-chat-backend-v2a branch 2 times, most recently from fdf8074 to 783ad0e Compare April 4, 2026 00:11

fjudith added 15 commits May 6, 2026 21:19

Added changeset

e5921e4

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

feat(mcp-chat): initial implementation of llm provider backend modules

eb6d42f

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

feat(mcp-chat): added support for amazon bedrock

9fac6ee

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

fix(mcp-chat): replace internal types references by the isomorphic pa…

ff66dee

…ckage Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

feat(mcp-chat): manage authentication using backstage integration aws…

e9aecf4

… package Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

feat(mcp-chat): added tests for amazon bedrock provider

47fb590

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

docs(mcp-chat): added configuration instructions for amazon bedrock

5db3175

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

feat(mcp-chat): restore unit tests for each llm provider

55bccda

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

fix(mcp-chat): restored examples

1936ec7

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

feat(mcp-chat): removed LLMProviderType

c9e9127

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

feat(mcp-chat): catchup latest upstream changes

294e68f

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

feat(mcp-chat): updated api reports

58ae947

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

feat(mcp-chat): moved base provider to node shared library

9478ced

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

feat(mcp-chat): restored backend integrated providers

952e2ae

see: comments backstage#8196 Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

feat(mcp-chat): updated api reports

88fb5c0

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

fjudith added 3 commits May 8, 2026 21:11

Added changeset

8871413

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

Merge branch 'main' into feat/mcp-chat-backend-v2a

71acba4

feat(mcp-chat): catch-up azure openai provider from upstream

789d777

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

fjudith requested review from Xantier, kurtaking and punkle as code owners May 9, 2026 01:31

backstage-service added the workspace/tech-insights Used to tag tech-insights workspace issues and pull requests label May 9, 2026

fix(mcp-chat): lockfile

e2d1a2f

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

Copilot AI review requested due to automatic review settings May 9, 2026 01:36

Copilot started reviewing on behalf of fjudith May 9, 2026 01:37 View session

Copilot AI reviewed May 9, 2026

View reviewed changes

fix(mcp-chat): potential fix for pull request finding

27a01fe

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Florian JUDITH <florian.judith.b@gmail.com>

Copilot AI review requested due to automatic review settings May 9, 2026 01:58

Copilot started reviewing on behalf of fjudith May 9, 2026 01:59 View session

fix(mcp-chat): update package publishing specs

84f773f

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

Copilot AI reviewed May 9, 2026

View reviewed changes

fjudith added 2 commits May 8, 2026 22:24

fix(mcp-chat): add missing extension point registration

a84a05d

doc: https://backstage.io/docs/backend-system/architecture/extension-points/#registering-an-extension-point Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

fix(mcp-chat): list appropriate packages

d6c9ba0

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

Copilot AI review requested due to automatic review settings May 9, 2026 02:31

Copilot started reviewing on behalf of fjudith May 9, 2026 02:32 View session

fjudith added 3 commits May 8, 2026 22:39

fix(mcp-chat): update remarks

3f0ab87

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

fix(mcp-chat): complete the list of dependent packages

2868f6d

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

fix(mcp-chat): resolve package publishing

6d87f36

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

Copilot AI reviewed May 9, 2026

View reviewed changes

fjudith added 3 commits May 8, 2026 22:53

fix(mcp-chat): updated api-reports

76d4620

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

Added changeset

e2e9076

Signed-off-by: Florian JUDITH <florian.judith@alithya.com>

Merge branch 'main' into feat/mcp-chat-backend-v2a

c507e0b

Copilot AI review requested due to automatic review settings May 11, 2026 00:30

Copilot started reviewing on behalf of fjudith May 11, 2026 00:30 View session

Copilot AI reviewed May 11, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(mcp-chat): added shared libraires and extension points#8370

feat(mcp-chat): added shared libraires and extension points#8370
fjudith wants to merge 34 commits into
backstage:mainfrom
alithya-oss:feat/mcp-chat-backend-v2a

fjudith commented Mar 30, 2026 •

edited

Loading

Uh oh!

backstage-goalie Bot commented Mar 30, 2026 •

edited

Loading

Uh oh!

fjudith commented Apr 5, 2026 •

edited

Loading

Uh oh!

Lucifergene commented May 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

fjudith commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Hey, I just made a Pull Request!

✔️ Checklist

Uh oh!

backstage-goalie Bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unexpected Changesets

Changed Packages

Uh oh!

fjudith commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Lucifergene commented May 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fjudith commented Mar 30, 2026 •

edited

Loading

backstage-goalie Bot commented Mar 30, 2026 •

edited

Loading

fjudith commented Apr 5, 2026 •

edited

Loading