Added register_boxed_system to Commands.#24213
Open
bytemuck wants to merge 2 commits intobevyengine:mainfrom
Open
Added register_boxed_system to Commands.#24213bytemuck wants to merge 2 commits intobevyengine:mainfrom
register_boxed_system to Commands.#24213bytemuck wants to merge 2 commits intobevyengine:mainfrom
Conversation
bytemuck
force-pushed
the
24017-add-register_boxed_system
branch
from
5bd0eb0 to
c800a9a
Compare
Contributor
|
The generated |
bytemuck
force-pushed
the
24017-add-register_boxed_system
branch
from
c800a9a to
ee6788c
Compare
Diddykonga
approved these changes
May 9, 2026
| commands.spawn(exclusive_callback); | ||
| } | ||
|
|
||
| // In many cases, you might want to use an observer to detect when a callback should run, |
Contributor
There was a problem hiding this comment.
Nit: If the comment suggests using an Observer, then an Observer should be used in the example.
Otherwise just change it to describe the System its over.
Contributor
Author
There was a problem hiding this comment.
Well, maybe we should also take a look to the callback example, as I copied it from there.
Maybe it is worth fixing both examples in this PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #24017
Solution
Added
register_boxed_systemtoCommands.Testing
callbacks_boxedexample.