Expose fxaa and smaa system as public for ordering constraints#24225
Open
komadori wants to merge 2 commits intobevyengine:mainfrom
Open
Expose fxaa and smaa system as public for ordering constraints#24225komadori wants to merge 2 commits intobevyengine:mainfrom
komadori wants to merge 2 commits intobevyengine:mainfrom
Conversation
JMS55
approved these changes
May 10, 2026
Contributor
Author
|
@alice-i-cecile Is it possible to add this PR to the 0.19 milestone? |
kfc35
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Encountered while porting the bevy_mod_outline ecosystem crate to Bevy 0.19-dev:
Previously, bevy_mod_outline's custom rendering pass ran in between tone-mapping and the anti-aliasing post-processes. This is because outlines are conceptually outside of the world. Rendering them before tone-mapping causes them to be visually affected by other objects in the scene which makes them look like they are part of it. This was accomplished in Bevy 0.18 by adding a render graph edge between the outline render node and the Tonemapping and Fxaa/Smaa nodes. However, with the migration to render-nodes-as-systems, the fxaa and smaa systems are not public and hence cannot be referenced in system ordering constraints.
Solution
Testing