Skip to content

Expose fxaa and smaa system as public for ordering constraints#24225

Open
komadori wants to merge 2 commits intobevyengine:mainfrom
komadori:expose-aa
Open

Expose fxaa and smaa system as public for ordering constraints#24225
komadori wants to merge 2 commits intobevyengine:mainfrom
komadori:expose-aa

Conversation

@komadori
Copy link
Copy Markdown
Contributor

Objective

Encountered while porting the bevy_mod_outline ecosystem crate to Bevy 0.19-dev:

Previously, bevy_mod_outline's custom rendering pass ran in between tone-mapping and the anti-aliasing post-processes. This is because outlines are conceptually outside of the world. Rendering them before tone-mapping causes them to be visually affected by other objects in the scene which makes them look like they are part of it. This was accomplished in Bevy 0.18 by adding a render graph edge between the outline render node and the Tonemapping and Fxaa/Smaa nodes. However, with the migration to render-nodes-as-systems, the fxaa and smaa systems are not public and hence cannot be referenced in system ordering constraints.

Solution

  • Change the fxaa and smaa systems from pub(crate) to pub.

Testing

  • Tested Bevy builds and the newly exposes systems can be referenced from an ordering constraint in a dependant crate.

@JMS55 JMS55 added D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels May 10, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering May 10, 2026
@komadori
Copy link
Copy Markdown
Contributor Author

@alice-i-cecile Is it possible to add this PR to the 0.19 milestone?

@kfc35 kfc35 added this to the 0.19 milestone May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Needs SME Triage

Development

Successfully merging this pull request may close these issues.

3 participants