Add page for available icons, do some JS cleanup#606
Merged
Conversation
jghiloni
commented
May 12, 2026
| your clipboard. You can also search using the text field below, with or without the `si/` | ||
| prefix. | ||
|
|
||
| <div id="icon-list" markdown> |
Contributor
Author
There was a problem hiding this comment.
both this div and the div on line 17 have the markdown attribute intentionally -- if you want to render markdown in a nested element, it's gotta be annotated from the root down to the actual container element
Contributor
Author
|
If accepted, this will also close #596 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a page Available Resource Icons to the root navigation next to Resource Types. It behaves similarly in its search functionality with a few notable differences:
In addition to adding that functionality, I made some improvements to the JS developer experience in the page:
list.jsis now an NPM dependency, rather than having to keep the minified copy / source map in overrides. I copied and improved the Typescript type definitions from@types/list.jsintosrc/typesto make it usable in Typescript.list.jsalso was causing an issue in the rollup build, due to its structure. By adding the rollupcommonjsplugin, it ensures that all modules are at least CommonJS modules before building, allowing it to complete with no errors.resource-types-list.mdto the root script bundle with a guard for the specific DOM elements existing.npm run start. I createddebugequivalent scripts thatnpm run startcalls that does not generate the source map OR minify the code, allowing the debugging to be much smoother.tools/icon-list/generate-icon-list.mjsruns in subsecond times on my macbook air.simple-iconsdependency to the version we use in concourse,mkdocs-materialuses an older version and the new version has a non-trivial number of new icons that don't render. I pegged to the version inmkdocs-materialand added a footnote.