fix: handle CNI config stat errors without panic#4890
Open
immanuwell wants to merge 1 commit into
Open
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
haytok
approved these changes
May 11, 2026
Member
haytok
left a comment
There was a problem hiding this comment.
Not sure if the scenario covered by TestFSExistsPropagatesStatError can happen via --cni-netconfpath from the CLI, but if os.Stat returns a non-NotExist error the current code panics on the nil, and returning the error instead is obviously safe. LGTM, Thanks!
sathiraumesh
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix for a CNI config path footgun.
If
--cni-netconfpath/$NETCONFPATHpoints at a regular file,fsExistsgets a stat error and then derefs a nilFileInfo. Boom: panic. This can happen from a bad local path, no weird infra limit needed.Repro:
TestFSExistsPropagatesStatErrorfrom this PR onmain.go test ./pkg/netutil -run TestFSExistsPropagatesStatError -count=1.pkg/netutil/store.go:56.This returns the stat error instead, and keeps missing-file behavior intact.
Tests:
go test ./pkg/netutil -run TestFSExistsPropagatesStatError -count=1go test ./pkg/netutil -count=1go test ./pkg/...