Add support for emrun --browser to point to a macOS browser app root path#26928
Merged
juj merged 2 commits intoMay 14, 2026
Merged
Conversation
…cOS app, and not the path to the executable inside the app. Fix emrun to also use this same convention.
sbc100
reviewed
May 13, 2026
| options = emrun_options = parse_args(args) | ||
|
|
||
| if MACOS and options.browser.endswith('.app') and not options.browser.startswith('open'): | ||
| options.browser_args = '--new --fresh --background -a ' + options.browser + ' ' + str(options.browser_args) |
sbc100
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The convention taken for
EMTEST_BROWSERis to have it point to the macOS app, and not the path to the executable inside the app. Fix emrun to also use this same convention.Fixes test
emrun.test_emrunon macOS, whenEMTEST_BROWSER=/Applications/Safari.apphttp://clbri.com:8010/api/v2/logs/434413/raw_inline