Allow emscripten_atomic_wait_suspending to return synchronously#26947
Open
sbc100 wants to merge 1 commit into
Open
Allow emscripten_atomic_wait_suspending to return synchronously#26947sbc100 wants to merge 1 commit into
sbc100 wants to merge 1 commit into
Conversation
sbc100
commented
May 14, 2026
| em_settled_result_t result = emscripten_promise_await(promise); | ||
| if (result.result != EM_PROMISE_FULFILL) { | ||
| __builtin_abort(); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Is there some way to avoid writing these three lines? i.e. should we have a version if emscripten_promise_await that lets rejected promises propogate to the top level instead of handling them ourselves?
sbc100
force-pushed
the
emscripten_atomic_wait_suspending2
branch
2 times, most recently
from
aece5ac to
3f54471
Compare
sbc100
commented
May 14, 2026
sbc100
force-pushed
the
emscripten_atomic_wait_suspending2
branch
2 times, most recently
from
39b92c5 to
2ad602d
Compare
Followup to the initial version landed in emscripten-core#26941
sbc100
force-pushed
the
emscripten_atomic_wait_suspending2
branch
from
2ad602d to
f2b3b85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to the initial version landed in #26941. This version of the code allows for reporting of synchronous results without actually suspending.