chore: remove uuid dependency#3130
Open
gameroman wants to merge 2 commits intofirebase:mainfrom
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces the external uuid dependency with the native crypto.randomUUID() method. A critical issue was identified in src/eventarc/eventarc-utils.ts where the crypto module is used without an explicit import, which will lead to a ReferenceError in Node.js 18 environments.
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the uuid dependency and replaces its usage with the native crypto.randomUUID() method in src/eventarc/eventarc-utils.ts and unit tests. Review feedback suggests improving the implementation by using the node: prefix for built-in module imports and adopting named imports for better clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.