Use ProcessInfo.beginActivity instead of IOPMAssertion#130
Open
edde746 wants to merge 1 commit intofluttercommunity:mainfrom
Open
Use ProcessInfo.beginActivity instead of IOPMAssertion#130edde746 wants to merge 1 commit intofluttercommunity:mainfrom
edde746 wants to merge 1 commit intofluttercommunity:mainfrom
Conversation
Replace the deprecated IOPMAssertionCreateWithName API with the modern ProcessInfo.processInfo.beginActivity() API for preventing display and system idle sleep on macOS. This is the Apple-recommended approach and works reliably on recent macOS versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the macOS wakelock implementation’s deprecated
kIOPMAssertionTypeNoDisplaySleepIOKit assertion withProcessInfo.beginActivity.Justification
The current implementation uses
kIOPMAssertionTypeNoDisplaySleep, which Apple’s SDK headers mark as deprecated since macOS 10.7 in favor ofkIOPMAssertPreventUserIdleDisplaySleep.ProcessInfo.beginActivityexpresses the plugin’s intent more directly: while wakelock is enabled, request both.idleDisplaySleepDisabledand.idleSystemSleepDisabled; when disabled, end the activity.This avoids deprecated assertion types and simplifies state tracking by storing the returned activity token instead of managing an
IOPMAssertionIDplus a separate boolean.Sources
ProcessInfo.beginActivity: https://developer.apple.com/documentation/foundation/processinfo/beginactivity(options:reason:)idleDisplaySleepDisabled: https://developer.apple.com/documentation/foundation/processinfo/activityoptions/idledisplaysleepdisabledidleSystemSleepDisabled: https://developer.apple.com/documentation/foundation/processinfo/activityoptions/idlesystemsleepdisabledkIOPMAssertionTypeNoDisplaySleep: https://developer.apple.com/documentation/iokit/kiopmassertiontypenodisplaysleep