Skip to content

feat(server): Add multipart upload endpoints#463

Draft
lcian wants to merge 8 commits intolcian/feat/multipart-upload-tieredfrom
lcian/feat/multipart-upload-endpoints
Draft

feat(server): Add multipart upload endpoints#463
lcian wants to merge 8 commits intolcian/feat/multipart-upload-tieredfrom
lcian/feat/multipart-upload-endpoints

Conversation

@lcian
Copy link
Copy Markdown
Member

@lcian lcian commented May 7, 2026

⚠️ stacked on #458

Implements the endpoints described in https://www.notion.so/sentry/Design-Multipart-uploads-3438b10e4b5d8009aeedcd8db91122ea?source=copy_link.

Close FS-341

@lcian lcian changed the base branch from main to lcian/feat/multipart-upload-tiered May 7, 2026 12:31
@lcian
Copy link
Copy Markdown
Member Author

lcian commented May 7, 2026

bugbot run

@lcian
Copy link
Copy Markdown
Member Author

lcian commented May 7, 2026

@sentry review

///
/// The default returns `None`. Backends that implement
/// [`MultipartUploadBackend`] should override this to return `Some(self)`.
fn as_multipart_upload_backend(&self) -> Option<&dyn MultipartUploadBackend> {
Copy link
Copy Markdown
Member Author

@lcian lcian May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory Backend should not know about MultipartUploadBackend, but this is the best way I found.

Comment thread objectstore-server/src/endpoints/multipart.rs
Comment thread objectstore-server/src/endpoints/multipart.rs
@lcian lcian changed the title lcian/feat/multipart upload endpoints feat(server): Add multipart upload endpoints May 7, 2026
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 7, 2026

@lcian
Copy link
Copy Markdown
Member Author

lcian commented May 7, 2026

bugbot run

@lcian
Copy link
Copy Markdown
Member Author

lcian commented May 7, 2026

@sentry review

Comment thread objectstore-server/src/endpoints/multipart.rs
@lcian
Copy link
Copy Markdown
Member Author

lcian commented May 7, 2026

bugbot run

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6413fd6. Configure here.

Comment thread objectstore-server/src/endpoints/multipart.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant