Skip to content

refactor(core): remove low-value [TopicTool] debug logs#26645

Open
jackwotherspoon wants to merge 5 commits intomainfrom
topics-debug-logs
Open

refactor(core): remove low-value [TopicTool] debug logs#26645
jackwotherspoon wants to merge 5 commits intomainfrom
topics-debug-logs

Conversation

@jackwotherspoon
Copy link
Copy Markdown
Collaborator

Summary

This PR removes low-value debug logs from the TopicTool that were cluttering the output during execution.

Details

  • Removed debugLogger.log in UpdateTopicInvocation.execute.
  • Removed the now-unused debugLogger import in packages/core/src/tools/topicTool.ts.

Related Issues

None.

How to Validate

  1. Run npm test -w @google/gemini-cli-core -- src/tools/topicTool.test.ts to ensure core functionality is unaffected.
  2. Build the package with npm run build -w @google/gemini-cli-core to verify no compilation errors.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@jackwotherspoon jackwotherspoon requested a review from a team as a code owner May 7, 2026 15:29
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a minor cleanup of the TopicTool implementation by removing unnecessary debug logging statements. The change improves the signal-to-noise ratio in the application logs without impacting core functionality.

Highlights

  • Code Cleanup: Removed low-value debug logs from the TopicTool execution flow to reduce console clutter.
  • Dependency Management: Removed the unused debugLogger import from the TopicTool source file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

🛑 Action Required: Evaluation Approval

Steering changes have been detected in this PR. To prevent regressions, a maintainer must approve the evaluation run before this PR can be merged.

Maintainers:

  1. Go to the Workflow Run Summary.
  2. Click the yellow 'Review deployments' button.
  3. Select the 'eval-gate' environment and click 'Approve'.

Once approved, the evaluation results will be posted here automatically.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the debugLogger import and its associated log statement from the UpdateTopicInvocation class within packages/core/src/tools/topicTool.ts. I have no feedback to provide as there were no review comments to evaluate.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Size Change: -132 B (0%)

Total Size: 34 MB

Filename Size Change
./bundle/chunk-543LOZI3.js 0 B -14.8 MB (removed) 🏆
./bundle/chunk-6Z5LXQY2.js 0 B -658 kB (removed) 🏆
./bundle/chunk-I5WWTRHF.js 0 B -3.43 kB (removed) 🏆
./bundle/chunk-KIOUSUTE.js 0 B -2.78 MB (removed) 🏆
./bundle/chunk-M6PLRH6H.js 0 B -19.5 kB (removed) 🏆
./bundle/chunk-QDVC4FLF.js 0 B -49.2 kB (removed) 🏆
./bundle/chunk-REUDQS7Z.js 0 B -3.8 kB (removed) 🏆
./bundle/chunk-RNQNROGM.js 0 B -12.5 kB (removed) 🏆
./bundle/core-7G7KFGDK.js 0 B -48.8 kB (removed) 🏆
./bundle/devtoolsService-FCISXW3B.js 0 B -28 kB (removed) 🏆
./bundle/gemini-5XNHQ22N.js 0 B -586 kB (removed) 🏆
./bundle/interactiveCli-TVPSDGSX.js 0 B -1.3 MB (removed) 🏆
./bundle/liteRtServerManager-V5DPL5CM.js 0 B -2.11 kB (removed) 🏆
./bundle/oauth2-provider-376D4N6N.js 0 B -9.16 kB (removed) 🏆
./bundle/chunk-5UR5JMXI.js 12.5 kB +12.5 kB (new file) 🆕
./bundle/chunk-76KPVOFS.js 3.43 kB +3.43 kB (new file) 🆕
./bundle/chunk-LSXP7H2X.js 2.78 MB +2.78 MB (new file) 🆕
./bundle/chunk-NUMEH5W5.js 49.2 kB +49.2 kB (new file) 🆕
./bundle/chunk-QGNG7STP.js 19.5 kB +19.5 kB (new file) 🆕
./bundle/chunk-UX4CD2IH.js 658 kB +658 kB (new file) 🆕
./bundle/chunk-VIVOBV6F.js 14.8 MB +14.8 MB (new file) 🆕
./bundle/chunk-XZKIVRB7.js 3.8 kB +3.8 kB (new file) 🆕
./bundle/core-DBASRGKU.js 48.8 kB +48.8 kB (new file) 🆕
./bundle/devtoolsService-V6SFUSVW.js 28 kB +28 kB (new file) 🆕
./bundle/gemini-45OGMN2E.js 586 kB +586 kB (new file) 🆕
./bundle/interactiveCli-6AO7AUH7.js 1.3 MB +1.3 MB (new file) 🆕
./bundle/liteRtServerManager-BZWOAACW.js 2.11 kB +2.11 kB (new file) 🆕
./bundle/oauth2-provider-XWO4US2W.js 9.16 kB +9.16 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./bundle/bundled/third_party/index.js 8 MB 0 B
./bundle/chunk-34MYV7JD.js 2.45 kB 0 B
./bundle/chunk-5AUYMPVF.js 858 B 0 B
./bundle/chunk-5PS3AYFU.js 1.18 kB 0 B
./bundle/chunk-664ZODQF.js 124 kB 0 B
./bundle/chunk-6NNHMYAM.js 1.97 MB 0 B
./bundle/chunk-DAHVX5MI.js 206 kB 0 B
./bundle/chunk-IUUIT4SU.js 56.5 kB 0 B
./bundle/chunk-RJTRUG2J.js 39.8 kB 0 B
./bundle/cleanup-VYKMG7GG.js 0 B -932 B (removed) 🏆
./bundle/devtools-36NN55EP.js 696 kB 0 B
./bundle/dist-T73EYRDX.js 356 B 0 B
./bundle/events-XB7DADIJ.js 418 B 0 B
./bundle/examples/hooks/scripts/on-start.js 188 B 0 B
./bundle/examples/mcp-server/example.js 1.43 kB 0 B
./bundle/gemini.js 5.1 kB 0 B
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB 0 B
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB 0 B
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB 0 B
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB 0 B
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB 0 B
./bundle/memoryDiscovery-QGLPGQCK.js 980 B 0 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 222 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 229 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 13.4 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B
./bundle/src-QVCVGIUX.js 47 kB 0 B
./bundle/start-WWNFQTWY.js 0 B -652 B (removed) 🏆
./bundle/tree-sitter-7U6MW5PS.js 274 kB 0 B
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB 0 B
./bundle/cleanup-LSMVZ2C3.js 932 B +932 B (new file) 🆕
./bundle/start-HDBKOVP4.js 652 B +652 B (new file) 🆕

compressed-size-action

@gemini-cli gemini-cli Bot added the status/need-issue Pull requests that need to have an associated issue. label May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants