Skip to content

Added out_sharding and qkv_sharding to MHA call method#5434

Open
vfdev-5 wants to merge 2 commits intomainfrom
mha-out_sharding
Open

Added out_sharding and qkv_sharding to MHA call method#5434
vfdev-5 wants to merge 2 commits intomainfrom
mha-out_sharding

Conversation

@vfdev-5
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 commented Apr 21, 2026

Added tests

What does this PR do?

Fixes # (issue)

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other checks if that's the case).
  • This change is discussed in a Github issue/discussion (please add a link).
  • The documentation and docstrings adhere to the documentation guidelines.
  • This change includes necessary high-coverage tests. (No quality testing = no merge!)

samanklesaria
samanklesaria approved these changes Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@samanklesaria samanklesaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@vfdev-5 vfdev-5 marked this pull request as ready for review April 23, 2026 21:29
@vfdev-5 vfdev-5 mentioned this pull request May 5, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samanklesaria samanklesaria samanklesaria approved these changes

@cgarciae cgarciae cgarciae approved these changes

Assignees

No one assigned

Labels

pull ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vfdev-5 @samanklesaria @cgarciae