AbstractFutureTest adding clinit test#8416
Closed
MarcoLe3 wants to merge 4 commits intogoogle:masterfrom
Closed
Conversation
…oops through all methods in AbstractFuture and see if theres a static initalizer.
…oops through all methods in AbstractFuture and see if theres a static initalizer.
Added a test case "testAssertNoClinit()" inside AbstractFutureTest.java which gathers the stream of "AbstractFuture".class and coverts into Bytes then parsed. Later loops all methods to find if class used does not contain a static initializer <clinit>. This test uses java.lang.classfile API (JDK 25). Ensuring AbstractFutureTest.java can be loaded without effects from static block and reducing potential deadlocks. Note: Included @SuppressWarnings("Java8ApiChecker") to allow the use of modern APIs within the Java 8-aligned test suite.
cpovirk
added
package=concurrent
type=other
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Added a test case "testAssertNoClinit()" inside AbstractFutureTest.java which gathers the stream of "AbstractFuture".class and coverts into Bytes then parsed. Later loops all methods to find if class used does not contain a static initializer . This test uses java.lang.classfile API (JDK 25). Ensuring AbstractFutureTest.java can be loaded without effects from static block and reducing potential deadlocks.
Note: Included @SuppressWarnings("Java8ApiChecker") to allow the use of modern APIs within the Java 8-aligned test suite.
@imports
References
I used this link for reference for the test case:
https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/classfile/package-summary.html