Support unix filepaths better with PathBuf#29
Merged
seddonym merged 1 commit intokraken-tech:mainfrom Aug 4, 2025
Merged
Conversation
LilyFirefly
force-pushed
the
use-pathbuf
branch
from
2bd0a7b to
8e13104
Compare
LilyFirefly
force-pushed
the
use-pathbuf
branch
3 times, most recently
from
93647c7 to
b05f3b9
Compare
LilyFirefly
added
enhancement
seddonym
requested changes
Aug 4, 2025
Collaborator
seddonym
left a comment
seddonym
left a comment
There was a problem hiding this comment.
Looks good but I think we should make sure there's test coverage for string inputs.
As this is a user-facing change, could we also update the README and CHANGELOG please?
|
|
||
|
|
||
| def test_en_basic(): | ||
| bundle = fluent.Bundle("en", [str(data_dir / "en.ftl")]) |
Collaborator
There was a problem hiding this comment.
Could we have a test that checks that strings are still supported?
LilyFirefly
force-pushed
the
use-pathbuf
branch
from
b05f3b9 to
5bf39bd
Compare
This is a bit more permissive on unix systems, where filenames don't have to be `utf-8`.
LilyFirefly
force-pushed
the
use-pathbuf
branch
from
5bf39bd to
3601046
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unix filepaths are not necessarily
utf-8, so representing them with Pythonstror RustStringisn't ideal. Python'spathlibhandles this, as does Rust'sPathBufand PyO3 knows how to convert between them.