Skip to content

feat: Support System.Diagnostics.DiagnosticSource version 10.*#254

Open
bstordrup wants to merge 1 commit into
launchdarkly:mainfrom
bstordrup:Issue-253_Support_10x
Open

feat: Support System.Diagnostics.DiagnosticSource version 10.*#254
bstordrup wants to merge 1 commit into
launchdarkly:mainfrom
bstordrup:Issue-253_Support_10x

Conversation

@bstordrup
Copy link
Copy Markdown

@bstordrup bstordrup commented May 6, 2026

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Provide links to any issues in this repository or elsewhere relating to this pull request.

Closes #253

Describe the solution you've provided

Raised the upper version range limit on System.Diagnostics.DiagnosticSource to 11 instead of 10

Describe alternatives you've considered

Considered to completely remove the upper limit, but decided for the upper limit raise as done in an earlier pull request (#149) to support version 9x of the same library.


Note

Low Risk
Low risk dependency-range change limited to the telemetry package project file; main risk is unexpected compatibility issues when consumers resolve newer DiagnosticSource versions.

Overview
Updates LaunchDarkly.ServerSdk.Telemetry.csproj to widen the System.Diagnostics.DiagnosticSource dependency upper bound from <10 to <11 for netstandard2.0/net462, enabling compatibility with 10.x versions (while keeping net8.0 relying on the built-in package).

Reviewed by Cursor Bugbot for commit 3836100. Bugbot is set up for automated code reviews on this repo. Configure here.

@bstordrup bstordrup requested a review from a team as a code owner May 6, 2026 12:42
@bstordrup bstordrup changed the title Support System.Diagnostics.DiagnosticSource version 10.* feat: Support System.Diagnostics.DiagnosticSource version 10.* May 6, 2026
@bstordrup
Copy link
Copy Markdown
Author

@launchdarkly/team-sdk-net, what is status?

@bstordrup bstordrup force-pushed the Issue-253_Support_10x branch from 3078c30 to 3836100 Compare May 13, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support version 10.x of System.Diagnostics.DiagnosticSource

1 participant