Skip to content

fix: resolve search icon alignment and background styling in docs#1033

Open
VIRAT-k82 wants to merge 5 commits into
layer5io:masterfrom
VIRAT-k82:fix/search-icon-ui
Open

fix: resolve search icon alignment and background styling in docs#1033
VIRAT-k82 wants to merge 5 commits into
layer5io:masterfrom
VIRAT-k82:fix/search-icon-ui

Conversation

@VIRAT-k82
Copy link
Copy Markdown
Contributor

@VIRAT-k82 VIRAT-k82 commented May 12, 2026

Notes for Reviewers

This PR resolves the UI styling and alignment issues with the search bar icon in the Cloud documentation.

Specifically, it:

  • Fixes the alignment of the search icon within the search bar.
  • Corrects the background styling (set to transparent) on focus state.
  • Ensures proper padding and layout for a better user experience.

Screenshots:
image

This PR fixes ##1017

Signed commits

  • Yes, I signed my commits.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the search project styles in SCSS and includes a re-ordering of the typescript dependency in the lockfile. Feedback focuses on correcting an invalid CSS value for background-color and removing dead, commented-out code to maintain stylesheet cleanliness.

Comment thread assets/scss/_search_project.scss Outdated
Comment thread assets/scss/_search_project.scss Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026

🚀 Preview deployment: https://layer5io.github.io/docs/pr-preview/pr-1033/

Note: Preview may take a moment (GitHub Pages deployment in progress). Please wait and refresh. Track deployment here

Copy link
Copy Markdown
Contributor Author

@VIRAT-k82 VIRAT-k82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

background color changes to transparent

@VIRAT-k82
Copy link
Copy Markdown
Contributor Author

@Rajesh-Nagarajan-11 pr is ready to review review it wheever you are free

Copy link
Copy Markdown
Member

@rishiraj38 rishiraj38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please tag the issue this PR is addressing.

@VIRAT-k82
Copy link
Copy Markdown
Contributor Author

@rishiraj38 now its all done and set!!!

Comment thread assets/scss/_search_project.scss Outdated
@VIRAT-k82 VIRAT-k82 force-pushed the fix/search-icon-ui branch 2 times, most recently from 60a96c6 to dad2029 Compare May 13, 2026 17:53
@VIRAT-k82 VIRAT-k82 closed this May 13, 2026
@VIRAT-k82 VIRAT-k82 force-pushed the fix/search-icon-ui branch from dad2029 to 54d9da0 Compare May 13, 2026 18:02
@VIRAT-k82 VIRAT-k82 reopened this May 13, 2026
@VIRAT-k82 VIRAT-k82 force-pushed the fix/search-icon-ui branch from 52b06cf to 4294d43 Compare May 13, 2026 18:30
VIRAT-k82 added 3 commits May 14, 2026 00:37
Signed-off-by: virat-k82 <viratkumar827921@gmail.com>
Signed-off-by: virat-k82 <viratkumar827921@gmail.com>
Signed-off-by: virat-k82 <viratkumar827921@gmail.com>
@VIRAT-k82 VIRAT-k82 force-pushed the fix/search-icon-ui branch from b35329f to 4f45e5c Compare May 13, 2026 19:09
@VIRAT-k82
Copy link
Copy Markdown
Contributor Author

@Rajesh-Nagarajan-11 i have perform all the task which needs to be done now it's completely ready!!!!

Comment thread package-lock.json
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert json file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants