chore(server): drop fixupMetadataError#40696
Conversation
…stream `Frame.expect` no longer mutates `progress.metadata.error` to synthesize an "Expect failed" entry for the library-mode case where the expect returns a result instead of throwing. Trace viewer and recorder now recognize the failure pattern themselves: when `metadata.method === 'expect'` and `result.matches === params.isNot`, treat it as an error. - Trace viewer: new `actionErrorMessage` helper in `traceModel.ts`, used by `_errorDescriptorsFromActions` (Errors tab) and `actionList.isError` (red title). - Recorder: matching `metadataError` helper in `recorderUtils.ts`, used by `metadataToCallLog` plus the in-flight retention and source-line color in `recorder.ts`. - Adds `pause.spec.ts › should populate log with expect failure` exercising the recorder path during a paused script.
Test results for "MCP"21 failed 6994 passed, 1058 skipped Merge workflow run. |
Test results for "tests 1"3 flaky41659 passed, 851 skipped Merge workflow run. |
1 participant
Summary
progress.metadata.errorfrom insideFrame.expectto fake an "Expect failed" entry for the library-mode case where expect returns a result.metadata.method === 'expect'andresult.matches === params.isNot, treat it as an error. New helpers:actionErrorMessageintraceModel.tsandmetadataErrorinrecorderUtils.ts.pause.spec.ts › should populate log with expect failurecovering the recorder path; the existingtrace-viewer.spec.ts › should highlight expect failurecovers the trace viewer path.