Feat/scrollbar track click#4
Open
xeen7 wants to merge 2 commits intomillionco:mainfrom
Open
Conversation
…X from 4px to .5px for better UX
|
@quebesinmars is attempting to deploy a commit to the Million Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes pointer-event handling and scroll position calculations for the terminal scrollbar, which could introduce regressions in scrolling/drag behavior across browsers and input types. Scope is limited to UI interaction and a small layout constant tweak.
Overview
Adds full track interaction to the terminal scrollbar: clicking the track now jumps the viewport to the clicked position and dragging can start from either the thumb or track.
Pointer handlers and pointer-capture logic move from the thumb element to the track, with visibility now toggling
pointer-eventson the track based on hover/drag/recent scroll. Also tweaks scrollbar placement by reducingTERMINAL_SCROLLBAR_TRACK_INSET_PXfrom4to0.5.Reviewed by Cursor Bugbot for commit 83a20ad. Bugbot is set up for automated code reviews on this repo. Configure here.