fix: resolve AttributeError in Encoding.is_special_token()#537
Open
HrushiYadav wants to merge 1 commit intoopenai:mainfrom
Open
fix: resolve AttributeError in Encoding.is_special_token()#537HrushiYadav wants to merge 1 commit intoopenai:mainfrom
HrushiYadav wants to merge 1 commit intoopenai:mainfrom
Conversation
is_special_token() references self._special_token_values which is never defined in __init__. Any call to enc.is_special_token(token_id) raises AttributeError. Changed to self._special_tokens.values() which correctly checks if the token id exists among the special token values. Added test for is_special_token with both special and regular tokens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #536
is_special_token()referencesself._special_token_valueswhich is never defined, causingAttributeErroron every callself._special_tokens.values()which correctly checks if the token id exists among the special token valuesis_special_tokenwith both special and regular tokensVerification
Test plan
Generated with Claude Code