Fix tensorboard() with newer TensorBoard versions#628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #626.
Newer TensorBoard releases no longer support
tensorboard --version_tb, which makestensorflow::tensorboard()fail while detecting the TensorBoard version. This updates version detection to usetensorboard --version.The PR also scopes a
PYTHONWARNINGSfilter to the spawned TensorBoard process to suppress TensorBoard'spkg_resourcesstartup deprecation warning without changing warning behavior in the parent R session.Public-facing changes
tensorflow::tensorboard()works with newer TensorBoard versions that removed--version_tb.Internal-only changes
Testing
devtools::load_all(); testthat::test_dir("tests/testthat")tensorboard()launch with TensorBoard 2.20.0