Skip to content

feat(sfs): add snapshot_policy_id to sfs_resource_pool#1444

Merged
marceljk merged 3 commits into
mainfrom
feat/STACKITTPR-629-add-snapshot-policy-id-in-sfs-resource-pool
May 13, 2026
Merged

feat(sfs): add snapshot_policy_id to sfs_resource_pool#1444
marceljk merged 3 commits into
mainfrom
feat/STACKITTPR-629-add-snapshot-policy-id-in-sfs-resource-pool

Conversation

@marceljk
Copy link
Copy Markdown
Contributor

@marceljk marceljk commented May 6, 2026

Description

relates to STACKITTPR-629

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@marceljk marceljk requested a review from a team as a code owner May 6, 2026 12:15
@marceljk marceljk force-pushed the feat/STACKITTPR-629-add-snapshot-policy-id-in-sfs-resource-pool branch from 6b2aaaf to 52faacd Compare May 6, 2026 12:23
Comment thread stackit/internal/services/sfs/resourcepool/resource.go Outdated
@marceljk marceljk force-pushed the feat/STACKITTPR-629-add-snapshot-policy-id-in-sfs-resource-pool branch from f5f3be8 to c332e2c Compare May 13, 2026 07:39
@marceljk marceljk force-pushed the feat/STACKITTPR-629-add-snapshot-policy-id-in-sfs-resource-pool branch from 3e32557 to aafd35a Compare May 13, 2026 13:17
@marceljk marceljk enabled auto-merge (squash) May 13, 2026 13:17
@marceljk marceljk merged commit bdeb987 into main May 13, 2026
3 checks passed
@marceljk marceljk deleted the feat/STACKITTPR-629-add-snapshot-policy-id-in-sfs-resource-pool branch May 13, 2026 13:19
@github-actions
Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/resourcepool 20.92% (+2.09%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/resourcepool/datasource.go 32.89% (+1.81%) 76 (+2) 25 (+2) 51 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/resourcepool/resource.go 17.27% (+2.31%) 249 (+15) 43 (+8) 206 (+7) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/resourcepool/datasource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/resourcepool/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/sfs_acc_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants