fix: inject false for unchecked boolean checkboxes in remote form submission#15786
fix: inject false for unchecked boolean checkboxes in remote form submission#15786PranavAgarkar07 wants to merge 1 commit intosveltejs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 39e3570 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
PranavAgarkar07
force-pushed
the
fix/unchecked-checkbox-remote-form
branch
from
08e2d70 to
d1edd02
Compare
|
Good catch, applied. Thanks! |
PranavAgarkar07
force-pushed
the
fix/unchecked-checkbox-remote-form
branch
from
d1edd02 to
39e3570
Compare
|
Unfortunately this can't work because it introduces a difference in behavior between enhanced and non-enhanced forms. If there's no JavaScript, the false value won't be injected. |
| event.preventDefault(); | ||
|
|
||
| const form_data = new FormData(form, event.submitter); | ||
| const form_data = get_form_data(form, event.submitter); |
There was a problem hiding this comment.
ottomated is right. We probably need to account for undefined checked values on the server rather than modifying the data on the client so that it works without JS on the client
| await expect(page.locator('#set-value-display')).toHaveText('Set via method'); | ||
| }); | ||
|
|
||
| test('unchecked checkbox submits successfully', async ({ page }) => { |
There was a problem hiding this comment.
We should probably move this test to test.js so that it's tested without JS too
|
Makes sense — preventing non-optional booleans at the schema level is the right fix since it works consistently with and without JS. Closing in favor of #15804. Thanks for the feedback @ottomated @teemingc! |
3 participants
Fixes #15785.
In SvelteKit 2.59.0, unchecked checkboxes using
z.coerce.boolean()failed to submit because the client-side form submission logic didn't account forb:-prefixed fields missing fromFormData.This PR adds a
get_form_datahelper inform.svelte.jsthat injects'false'into theFormDatafor anyb:-prefixed input that is absent from theFormData(i.e. unchecked checkboxes).A regression test has been added to
packages/kit/test/apps/asyncto verify that unchecked checkboxes submit successfully.