Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,14 @@ def _wrap(
)
_handle_input(span, event_logger, llm_request_type, kwargs)

response = wrapped(*args, **kwargs)
try:
response = wrapped(*args, **kwargs)
except Exception as exc:
if span.is_recording():
span.record_exception(exc)
span.set_status(Status(StatusCode.ERROR, str(exc)))
span.end()
raise

if response:
_handle_response(span, event_logger, llm_request_type, response)
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
from unittest.mock import MagicMock

import pytest
from opentelemetry.trace.status import StatusCode

from opentelemetry.instrumentation.together import _wrap


def _make_wrapper():
tracer = MagicMock()
span = MagicMock()
span.is_recording.return_value = True
tracer.start_span.return_value = span

wrapper = _wrap(tracer, None, {"method": "chat.completions.ChatCompletions.create", "span_name": "together.chat"})
return span, wrapper


def test_chat_api_error_marks_span_failed():
span, wrapper = _make_wrapper()
wrapped = MagicMock(side_effect=RuntimeError("401 Unauthorized"))

with pytest.raises(RuntimeError, match="401 Unauthorized"):
wrapper(wrapped, None, [], {"model": "test-model"})

exc_arg = span.record_exception.call_args.args[0]
assert isinstance(exc_arg, RuntimeError)
assert "401 Unauthorized" in str(exc_arg)
span.set_status.assert_called_once()
span.end.assert_called_once()


def test_chat_api_error_records_exception_message():
span, wrapper = _make_wrapper()
wrapped = MagicMock(side_effect=ValueError("bad request"))

with pytest.raises(ValueError, match="bad request"):
wrapper(wrapped, None, [], {"model": "test-model"})

status_arg = span.set_status.call_args.args[0]
assert status_arg.status_code == StatusCode.ERROR
assert status_arg.description == "bad request"
span.end.assert_called_once()
2 changes: 1 addition & 1 deletion packages/opentelemetry-instrumentation-together/uv.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.