test(hypervisors): add unit tests for CloudHypervisor#617
Open
r0hansaxena wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for urunc canceled.
|
Signed-off-by: r0hansaxena <rohansxn8772@gmail.com>
r0hansaxena
force-pushed
the
test/cloud-hypervisor
branch
from
4d233e4 to
df20eb8
Compare
cmainas
reviewed
May 12, 2026
Contributor
cmainas
left a comment
cmainas
left a comment
There was a problem hiding this comment.
Hello @r0hansaxena ,
thank you for the PR. I have added some comments
| } | ||
| } | ||
|
|
||
| func TestCloudHypervisorUsesKVM(t *testing.T) { |
Contributor
There was a problem hiding this comment.
No reason to test such a small and straightforward action through unit tests
| assert.True(t, newTestCH().UsesKVM()) | ||
| } | ||
|
|
||
| func TestCloudHypervisorOk(t *testing.T) { |
Contributor
There was a problem hiding this comment.
I do not really see the value of such a unit test.
| assert.NoError(t, newTestCH().Ok()) | ||
| } | ||
|
|
||
| func TestCloudHypervisorPath(t *testing.T) { |
Contributor
There was a problem hiding this comment.
This tests the function that you created before...
| assert.Equal(t, "/usr/bin/cloud-hypervisor", newTestCH().Path()) | ||
| } | ||
|
|
||
| func TestCloudHypervisorPreExec(t *testing.T) { |
Contributor
There was a problem hiding this comment.
No reason to test such a small and straightforward action through unit tests
Contributor
There was a problem hiding this comment.
Please do not add new files for mocking functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds unit tests for the CloudHypervisor VMM backend, covering BuildExecCmd and the simpler interface methods (UsesKVM, Ok, Path, PreExec, SupportsSharedfs). Tests are table-driven and cover all flag-generation branches including memory, networking, block devices, initrd, virtiofs and vsock.
Related issues
How was this tested?
Ran unit tests locally:
All 20 test cases passed. Full package tests also pass:
Linter passes locally (make lint, 0 issues).
LLM usage
Claude Sonnet 4.6 was used to assist with writing the tests. All code was reviewed and tested locally before submission.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).