chore: set up konsistent with basic initial config for package, adapter, and state adapter conventions#466
Open
felixarntz wants to merge 15 commits intomainfrom
Open
chore: set up konsistent with basic initial config for package, adapter, and state adapter conventions#466felixarntz wants to merge 15 commits intomainfrom
konsistent with basic initial config for package, adapter, and state adapter conventions#466felixarntz wants to merge 15 commits intomainfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Author
|
@dancer Current inconsistencies flagged: I think most of them are trivial to fix, falling in one of the following categories:
Two questions:
|
bensabic
reviewed
May 9, 2026
| "@changesets/cli": "^2.29.8", | ||
| "@vitest/coverage-v8": "^4.0.18", | ||
| "knip": "^5.85.0", | ||
| "konsistent": "0.0.1-alpha.20", |
Contributor
There was a problem hiding this comment.
Only stable versions should be used for the Chat SDK repo, in case anything breaks.
…er from createSlackAdapter
…pter type in index.ts
…t + map kebab to PascalCase
CHANGELOG.md is generated automatically by changesets on each release — it's never hand-authored and doesn't exist for a package until its first release lands. Requiring it as a convention check makes CI fail indefinitely for any newly added package, with no honest fix available (an empty placeholder is just noise that gets overwritten on first release).
bensabic
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
konsistentfor the repo with a basic config that ensures consistency in package files, adapters' and state adapters' external API surfaceTest plan
Run
pnpm konsistentfrom the root of the repo.Checklist
pnpm validatepasses