Skip to content

test: build runtime-vapor in cjs for pkg.pr.new#14418

Draft
zhiyuanzmj wants to merge 6 commits intovuejs:minorfrom
zhiyuanzmj:cjs-vapor
Draft

test: build runtime-vapor in cjs for pkg.pr.new#14418
zhiyuanzmj wants to merge 6 commits intovuejs:minorfrom
zhiyuanzmj:cjs-vapor

Conversation

@zhiyuanzmj
Copy link
Copy Markdown
Member

just a test

Copilot AI review requested due to automatic review settings February 5, 2026 06:06
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 5, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 25b3b1e2-e5fa-4f7c-b06b-c22b3b649628

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 5, 2026

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14418
npm i https://pkg.pr.new/@vue/compiler-core@14418
yarn add https://pkg.pr.new/@vue/compiler-core@14418.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14418
npm i https://pkg.pr.new/@vue/compiler-dom@14418
yarn add https://pkg.pr.new/@vue/compiler-dom@14418.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14418
npm i https://pkg.pr.new/@vue/compiler-sfc@14418
yarn add https://pkg.pr.new/@vue/compiler-sfc@14418.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14418
npm i https://pkg.pr.new/@vue/compiler-ssr@14418
yarn add https://pkg.pr.new/@vue/compiler-ssr@14418.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14418
npm i https://pkg.pr.new/@vue/compiler-vapor@14418
yarn add https://pkg.pr.new/@vue/compiler-vapor@14418.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14418
npm i https://pkg.pr.new/@vue/reactivity@14418
yarn add https://pkg.pr.new/@vue/reactivity@14418.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14418
npm i https://pkg.pr.new/@vue/runtime-core@14418
yarn add https://pkg.pr.new/@vue/runtime-core@14418.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14418
npm i https://pkg.pr.new/@vue/runtime-dom@14418
yarn add https://pkg.pr.new/@vue/runtime-dom@14418.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14418
npm i https://pkg.pr.new/@vue/runtime-vapor@14418
yarn add https://pkg.pr.new/@vue/runtime-vapor@14418.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14418
npm i https://pkg.pr.new/@vue/server-renderer@14418
yarn add https://pkg.pr.new/@vue/server-renderer@14418.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14418
npm i https://pkg.pr.new/@vue/shared@14418
yarn add https://pkg.pr.new/@vue/shared@14418.tgz

vue

pnpm add https://pkg.pr.new/vue@14418
npm i https://pkg.pr.new/vue@14418
yarn add https://pkg.pr.new/vue@14418.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14418
npm i https://pkg.pr.new/@vue/compat@14418
yarn add https://pkg.pr.new/@vue/compat@14418.tgz

commit: 3830b81

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 5, 2026

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 86.4 kB 30.3 kB 26.6 kB
runtime-dom.global.prod.js 125 kB (+12.6 kB) 47.6 kB (+5.21 kB) 42.5 kB (+4.49 kB)
vue.global.prod.js 259 kB (+86.8 kB) 92.2 kB (+30 kB) 80.4 kB (+24.9 kB)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 51.3 kB 20 kB 18.3 kB
createApp 60.4 kB 23.3 kB 21.2 kB
createApp + vaporInteropPlugin 101 kB 36.2 kB 32.8 kB
createVaporApp 27.4 kB 10.7 kB 9.77 kB
createSSRApp 64.9 kB 25.1 kB 22.8 kB
createVaporSSRApp 32.9 kB 12.6 kB 11.6 kB
defineCustomElement 67 kB 25.3 kB 23 kB
defineVaporCustomElement 40.1 kB 14.3 kB 13.1 kB
overall 75.4 kB 28.7 kB 26.1 kB

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to include runtime-vapor exports in CJS builds for pkg.pr.new testing. However, the implementation has significant architectural issues.

Changes:

  • Disables the trimVaporExportsPlugin that normally excludes vapor exports from non-vapor builds
  • Adds vapor exports to standard runtime.ts and index.ts files
  • Removes vapor exports from the files specifically named "with-vapor"

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
scripts/trim-vapor-exports.js Comments out the plugin that trims vapor exports from runtime builds
packages/vue/src/runtime.ts Adds vapor exports to the standard runtime-only build
packages/vue/src/runtime-with-vapor.ts Removes direct vapor export (but still includes it via runtime.ts import)
packages/vue/src/index.ts Adds vapor exports to the standard full build with compiler
packages/vue/src/index-with-vapor.ts Removes direct vapor export (but still includes it via index.ts import)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/vue/src/runtime-with-vapor.ts Outdated
Comment thread packages/vue/src/index-with-vapor.ts Outdated
Comment thread packages/vue/src/runtime.ts
Comment thread packages/vue/src/index.ts
Comment thread scripts/trim-vapor-exports.js
Comment thread scripts/trim-vapor-exports.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants