-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
fix(hydration): route hydration mismatch errors through handleError (fix #13154) #14757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pierluigilenoci
wants to merge
1
commit into
vuejs:main
Choose a base branch
from
pierluigilenoci:fix/hydration-error-handler
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+127
−11
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
Preserve the old fallback when no error handler is present.
handleError(..., false)still goes throughlogError(), which adds a new dev warning (Unhandled error during execution of hydration) beforeconsole.error(err). That means unhandled hydration mismatches now emit extra generic noise in dev, even though the old behavior was just the specific mismatch warning plus the one-off console error.Please gate the
handleError()path on an actual consumer (app.config.errorHandler/ ancestorerrorCaptured) and keep the old directconsole.error(new Error(...))fallback otherwise.Proposed fix
const logMismatchError = ( instance: ComponentInternalInstance | null = null, ) => { if (hasLoggedMismatchError) { return } hasLoggedMismatchError = true - // Route through Vue's error handling pipeline so that - // onErrorCaptured and app.config.errorHandler can catch it. - if (__TEST__) { - // In test mode, only route through handleError if an error handler is - // actually configured (errorHandler or onErrorCaptured), to avoid adding - // unexpected "Unhandled error" warnings to every mismatch test. - if ( - instance && - (instance.appContext.config.errorHandler || hasErrorCaptured(instance)) - ) { - handleError( - new Error('Hydration completed but contains mismatches.'), - instance, - ErrorCodes.HYDRATION_MISMATCH, - false, - ) - } - } else { - handleError( - new Error('Hydration completed but contains mismatches.'), - instance, - ErrorCodes.HYDRATION_MISMATCH, - false, - ) - } + const err = new Error('Hydration completed but contains mismatches.') + const hasConsumer = + !!instance && + (instance.appContext.config.errorHandler || hasErrorCaptured(instance)) + + if (hasConsumer) { + handleError(err, instance, ErrorCodes.HYDRATION_MISMATCH, false) + } else if (!__TEST__) { + console.error(err) + } }📝 Committable suggestion
🤖 Prompt for AI Agents