Add emscripten_atomic_wait_suspending for ASYNCIFY/JSPI#26941
Merged
sbc100 merged 1 commit intoMay 14, 2026
Conversation
sbc100
force-pushed
the
emscripten_atomic_wait_suspending
branch
2 times, most recently
from
7258f6e to
aa90c53
Compare
sbc100
changed the title
emscripten_atomic_wait_suspending for ASYNCIFY/JSPI
sbc100
force-pushed
the
emscripten_atomic_wait_suspending
branch
2 times, most recently
from
0d3ee83 to
d410445
Compare
tlively
reviewed
May 13, 2026
sbc100
force-pushed
the
emscripten_atomic_wait_suspending
branch
3 times, most recently
from
d9ff264 to
352fb30
Compare
Collaborator
Author
|
OK, after chatting online I agreed to make the sometimes-suspending version as a followup. In fact its already here: bca3e2d But I'd still like to land this first and then discussion that change separately if that's ok? |
This works very much like the existing emscripten_atomic_wait_async but using `ASYNCIFY`/`JSPI` to suspend execution until the `waitAsync` operation is done. The test here ends up depending on the internal `_emscripten_thread_set_strongref` function unfortunately.
sbc100
force-pushed
the
emscripten_atomic_wait_suspending
branch
from
352fb30 to
1b1da4a
Compare
tlively
approved these changes
May 14, 2026
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 14, 2026
Followup to the initial version landed in emscripten-core#26941
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 14, 2026
Followup to the initial version landed in emscripten-core#26941
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 14, 2026
Followup to the initial version landed in emscripten-core#26941
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 14, 2026
Followup to the initial version landed in emscripten-core#26941
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 14, 2026
Followup to the initial version landed in emscripten-core#26941
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 14, 2026
Followup to the initial version landed in emscripten-core#26941
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 14, 2026
Followup to the initial version landed in emscripten-core#26941
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 15, 2026
Followup to the initial version landed in emscripten-core#26941
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 15, 2026
Followup to the initial version landed in emscripten-core#26941
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 15, 2026
Followup to the initial version landed in emscripten-core#26941
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works very much like the existing
emscripten_atomic_wait_asyncbut usingASYNCIFY/JSPIto suspend execution until thewaitAsyncoperation is done.